Studio dvcyaml #709
Merged
Studio dvcyaml #709
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch has no changes to coverable lines.
📢 Thoughts on this report? Let us know!. |
dberenbaum
commented
Sep 12, 2023
Comment on lines
+140
to
+141
| .dvc/ | ||
| .dvcignore |
There was a problem hiding this comment.
Unrelated, but I keep getting these generated when running tests
daavoo
approved these changes
Sep 13, 2023
|
Yes, this depends on both iterative/dvc#9898 and https://github.com/iterative/studio/pull/7628. We can either wait to merge it into the 3.0 branch, or merge now and wait for those changes to release 3.0. |
|
Actually, we don't technically need a dvc version bump in dvclive, at least for this PR, since this only affects Studio. Probably good to do it anyway to avoid weird plots issues in 3.0, so I added it here. |
daavoo
added a commit
that referenced
this pull request
Sep 20, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <[email protected]> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Bump dvc and dvc-render --------- Co-authored-by: dberenbaum <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
skshetry
pushed a commit
that referenced
this pull request
Sep 21, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <[email protected]> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * track dvcyaml file * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * drop unneeded relpath call * drop extra make_report call --------- Co-authored-by: daavoo <[email protected]>
daavoo
added a commit
that referenced
this pull request
Sep 21, 2023
* live: Set new defaults `report=None` and `save_dvc_exp=True`. * frameworks: Drop model_file. * update examples * Write to root dvc.yaml (#687) * add dvcyaml to root * clean up dvcyaml implementation * fix existing tests * add new tests * add unit tests for updating dvcyaml * use posix paths * don't resolve symlinks * drop entire dvclive dir on cleanup * fix studio tests * revert cleanup changes * unify rel_path util func * cleanup test * refactor tests * add test for multiple dvclive instances * put dvc_file logic into _init_dvc_file --------- Co-authored-by: daavoo <[email protected]> * report: Drop "auto" logic. Fallback to `None` when conditions are not met for other types. * studio: Extract `post_to_studio` and decoulple from `make_report` (#705) * refactor(tests): Split `test_main` into separate files. Rename test_frameworks to frameworks. * fix matplotlib warning * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * track dvcyaml file * Studio dvcyaml (#709) * drop dvc.yaml prefix from studio plots * refactor * drop .dvc files * dvc version bump * drop unneeded relpath call * drop extra make_report call * test for git add dvc.yaml in exp run --------- Co-authored-by: daavoo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make posts to studio drop
dvc.yaml::from plots